[PvP] PvP scaling system with DBC coefficients, dampening, trinket set bonus#11249
Open
followingthefasciaplane wants to merge 5 commits intosimulationcraft:midnightfrom
Open
[PvP] PvP scaling system with DBC coefficients, dampening, trinket set bonus#11249followingthefasciaplane wants to merge 5 commits intosimulationcraft:midnightfrom
followingthefasciaplane wants to merge 5 commits intosimulationcraft:midnightfrom
Conversation
Member
|
Parsing of pvp data, both aura data and on effects can be handled by existing systems. All that is required is for said existing parse systems to support pvp effects. The large set of coefficient options provided should not be configurable by users, as you cannot change these values in game directly. Support for pvp would also require APLs, pvp talent implementations and likely additional features in the raid events system, none of which presently exist. I'd be reticent to merge such a large set of changes from someone who isn't already somewhat active in the community around simc, due to concerns about continued support for the features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overrides are still not entirely implemented, but I would appreciate a review. Documentation is found in
/engine/sim/pvp_scaling.hpp